On Mon, Jul 16, 2012 at 11:01:44AM -0400, Theodore Ts'o wrote: > On Sun, Jul 01, 2012 at 09:48:28PM +0800, Zheng Liu wrote: > > From: Zheng Liu <wenqing.lz@xxxxxxxxxx> > > > > Add EXT4_INLINE_DATA_FL flag. > > > > /* EXT4_EOFBLOCKS_FL 0x00400000 was here */ > > +#define EXT4_INLINE_DATA_FL 0x00800000 /* Inode has inline data */ > > Hi, > > Unfortunately, we have a codepoint collision. The BTRFS folks have > already exposed FS_NOCOW_FL as 0x00800000; this is in mainline in the > kernel, and in fact that latest version of e2fsprogs understands this > since lsattr and chattr are used by multiple file systems (even though > it was originally intended only for ext2/3/4). > > I'd like to move this to: > > #define EXT4_INLINE_DATA_FL 0x10000000 /* Inode has inline data */ > > However, if you already have this in production internally inside > Taobao, this could potentially could be a problem for you. (We've had > to handle this before inside Google, when we used a different code > point for EOFBLOCKS_FL than what ended up being used in mainline; it > can be dealt with, but it's certainly annoying...) > > Is this going to potentially be a problem for you? Hi Ted, I have discussed this issue with Tao, and it is not a problem for us. So we could change it to '0x10000000'. :) Regards, Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
