On 7/3/2012 3:27 PM, Andrew Morton wrote: > On Thu, 28 Jun 2012 11:32:09 -0700 > Scan Subscription <scan-subscription@xxxxxxxxxxxx> wrote: > > ____________________________________________________________________________________________________________ > CID 703581 - NO_EFFECT Unsigned compared against 0 - This less-than-zero comparison of an unsigned value is never true. "*val < 0UL". > > drivers/scsi/fcoe/fcoe_sysfs.c:105 > 100 static int fcoe_str_to_dev_loss(const char *buf, unsigned long *val) > 101 { > 102 int ret; > 103 > 104 ret = kstrtoul(buf, 0, val); >>>>> CID 703581: Unsigned compared against 0 (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "*val < 0UL". >> 105 if (ret || *val < 0) >> 106 return -EINVAL; >> 107 /* >> 108 * Check for overflow; dev_loss_tmo is u32 >> Patch posted to linux-scsi. Thanks, //Rob-- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html