Hi, On Mon 02-07-12 21:14:58, Andrew Perepechko wrote: > So you think the correct fix would be to remove the check completely > since every try_to_release_page() caller is obliged to perform the > page_has_private() check? Yes, I think that would be reasonable. XFS already relies on this so it should be safe. Honza > On 07/02/2012 09:09 PM, Jan Kara wrote: > >On Fri 29-06-12 20:52:51, Andrew Perepechko wrote: > >>This does not lead to oom or any similar issue since calls to > >>try_to_release_page() > >>are accompanied by page_has_private() checks. > >> > >> > > The check is a dead code because ->release_page() is called only if > >PagePrivate bit is set. > > > > Honza > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
