On 06/09/2012 12:59 AM, Al Viro wrote:
> On Wed, May 30, 2012 at 01:39:08PM +0300, Boaz Harrosh wrote:
>> + ret = d_splice_alias(inode, dentry);
>> + if (IS_ERR(ret)) {
>> + EXOFS_ERR("directory #%lu corrupted", dir->i_ino);
>> + iput(inode);
>
> That's a bloody wrong interface. If you add d_splice_alias() failure
> exit like that, do iput() *there*. Requiring every caller to deal with
> failure exit cleanups like that is the recipe for recurring bugs.
> Don't Do That.
I agree. Thanks.
My point being that please any changes made to ext2, in this area please also
apply to exofs, since it is just another copy/paste of ext2. I'll ACK any
which way you guys decide to properly go with, as part of the VFS changes.
Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
