On 2012-05-28, at 7:28 PM, Ted Ts'o wrote: > On Mon, May 28, 2012 at 04:58:24PM -0600, Andreas Dilger wrote: >> Change the e2fsck/mke2fs/tune2fs/e2image/debugfs regression tests >> to be driven by Makefile rules instead of by a script loop. This >> allows the tests to be run in parallel like a build and reduces >> testing time significantly. > > Applied with some fixes; test_script was still working correctly with > VPATH. Also, removing the writeable flag from test_one and > test_script means that Makefile will get a "permission denied" if it > needs to rebuild those two files. Hrm, one reason I made the generated files read-only is to avoid accidentally editing the generated copy, and then losing the resulting changes when the file is recreated (as happened several times with the test_script file, when rebasing the patch). I'd prefer to mark the generated files read-only, and then have the Makefile rules delete the file before recreating it. That avoids accidentally having developers edit the file, while allowing the always-remembering Makefile rule to recreate the file without errors. Cheers, Andreas -- Andreas Dilger Whamcloud, Inc. Principal Lustre Engineer http://www.whamcloud.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
