On 2012-04-24, at 4:07 PM, Bernd Schubert wrote: >> 1) For SEEK_END, we now return -EINVAL for a positive offset (i.e. past EOF) > > I definitely introduces that one, as I cannot see how an application > might ever run into it. Especially as ext4 directories cannot shrink. So > if an application tries to exceed the directory size limit, it looks to > me as some of attempt to break something or as an error in the > application. However, if there should be the slightest chance to break > existing applications relying on that, we need to remove that. I think the other reason to avoid SEEK_END + n is that since SEEK_END for a hash offset is (signed) MAX_LONG, so if one seeks beyond that it will wrap to a negative offset. Cheers, Andreas -- Andreas Dilger Whamcloud, Inc. Principal Lustre Engineer http://www.whamcloud.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
