On Tue 03-04-12 12:49:18, Artem Bityutskiy wrote: > From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx> > > Jan Kara removed 'sb->s_dirt' VFS flag references, so we do not need to > register the ext2 'ext2_write_super()' method in the VFS superblock operations, > because 'sb->s_dirt' won't be ever set to 1 and VFS won't ever call > '->write_super()' anyway. Thus, remove the method. > > Tested using xfstests. > > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx> Thanks. Added to my tree. Honza > --- > fs/ext2/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index a43f9ad..e0e8f45 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -302,7 +302,6 @@ static const struct super_operations ext2_sops = { > .write_inode = ext2_write_inode, > .evict_inode = ext2_evict_inode, > .put_super = ext2_put_super, > - .write_super = ext2_write_super, > .sync_fs = ext2_sync_fs, > .statfs = ext2_statfs, > .remount_fs = ext2_remount, > -- > 1.7.7.6 > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html