Re: [RFC, PATCH] Avoid hot statistics cache line in ext4 extent cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andi --

I realized the problem soon after the original patch, and submitted
another patch to make these per cpu  counters.

http://patchwork.ozlabs.org/patch/124213/

However, looks like that fell through the cracks.

Andreas, Ted --  could you please take a look at that patch?

Andi --  perhaps you could patch it in  and check if  you still see
the hot cache line?

On Fri, Mar 23, 2012 at 8:13 PM, Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:
>> The patch only disables the statistics counting, but not the sysfs
>> files that will now report bogus statistics.  I don't disagree with
>> disabling these stats, but if you are disabling the accounting you
>> should also comment out the functions in fs/ext4/super.c that are
>> printing out these statistics.
>
> Aware of that -- that is why it was just a RFC.
> The choice is between per cpu counters or completely removing them.
> I would prefer the later.
>
> -Andi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux