Peter, Note that we are planning on unexporting ext2_fs.h, and then utterly removing it from the tree (with what fs/ext2 needs being moved to fs/ext2/ext2.h). Someone who was compiling "the latest version" of syslinux has submitted a kernel bugzilla entry that this was breaking due to ext2_fs.h using umode_t which was no longer being exported by the kernel header files. Given that ext2_fs.h is about to go ***poof*** (Al already has the changes in his vfs git tree), I thought I should give you a heads up.... - Ted On Fri, Mar 23, 2012 at 05:55:34PM +0000, Al Viro wrote: > On Fri, Mar 23, 2012 at 09:13:31AM -0400, Ted Ts'o wrote: > > On Fri, Mar 23, 2012 at 10:27:36AM +0100, Thierry Reding wrote: > > > Since the on-disk format has been stable for quite some time, users > > > should either use the headers provided by libext2fs or keep a private > > > copy of this header. For the full discussion, see this thread: > > > > > > https://lkml.org/lkml/2012/3/21/516 > > > > > > While at it, this commit removes all __KERNEL__ guards, which are now > > > unnecessary. > > > > > > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > > > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > > > Cc: Jan Kara <jack@xxxxxxx> > > > Cc: Ted Ts'o <tytso@xxxxxxx> > > > Cc: Artem Bityutskiy <dedekind1@xxxxxxxxx> > > > Cc: Andreas Dilger <aedilger@xxxxxxxxx> > > > Cc: linux-ext4@xxxxxxxxxxxxxxx > > > > Acked-by: "Theodore Ts'o" <tytso@xxxxxxx> > > > > Thanks!! > > > > Al, do you want to take this in the VFS tree, or do you want me to > > carry this in the ext4 tree? Or Jan could carry it in the ext2 tree. > > I don't really have strong feelings about who picks it up. I will if > > no one else wants to... > > Applied. I'll probably add a followup moving most of that stuff to > fs/ext2/ext2.h on top of that commit... > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
