On Mon, Mar 05, 2012 at 01:37:57PM +0100, Jan Kara wrote: > On Fri 02-03-12 13:11:55, Lukas Czerner wrote: > > The overflow can happen when we are calling get_group_no_and_offset() > > which stores the group number in the ext4_grpblk_t type which is > > actually int. However when the blocknr is big enough the group number > > might be bigger than ext4_grpblk_t resulting in overflow. This will > > most likely happen with FITRIM default argument len = ULLONG_MAX. > > > > Fix this by using "end" variable instead of "start+len" as it is easier > > to get right and specifically check that the end is not beyond the end > > of the file system, so we are sure that the result of > > get_group_no_and_offset() will not overflow. Otherwise truncate it to > > the size of the file system. > Looks good. You can add: > Reviewed-by: Jan Kara <jack@xxxxxxx> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
