Re: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 20, 2012 at 03:10:01AM -0400, David Miller wrote:
> > OK. Say I'm a scraper.  How do I distinguish between:
> > 
> > pr_info("foo");
> > printk(KERN_INFO "foo");
> > 
> > Oh my. seems that both result in exactly the same thing ending up in the
> > dmesg buffer
> 
> No it doesn't result in the same output, read the definitions again.
> 
> pr_info can be influenced by pr_fmt, plain printk cannot

But if you don't use pr_fmt, it's the same.  And even if you do, then
pr_info() is the same as printk(KERN_INFO pr_fmt ...).  For a device
driver where cut and paste reuse happens, sure, it's handy.  But for
the rest of the kernel, it doesn't really buy you anything.  

And as I've said, something like ext4_msg(sb, ...) is **far** more
useful.  I don't need a 1200-line patch that messes with debug
printk's that are #ifdef'ed out.

     	   	     	  	       	       - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux