On Fri, 2012-03-16 at 09:03 -0700, David Daney wrote: > On 03/15/2012 05:07 PM, Joe Perches wrote: > > Add -DDEBUG to enable future use of pr_debug. > > No changes to objects as no DEBUG uses currently exist. [] > > diff --git a/fs/ext4/Makefile b/fs/ext4/Makefile [] > > +ccflags-$(CONFIG_EXT4_FS) := -DDEBUG > In many other susbsystems/drivers, the definition of DEBUG is gated by a > separate Kconfig symbol used to select debugging just for that > susbsystem/driver (see CONFIG_MMC_DEBUG for example). > > Why aren't you doing the same here? It can be done later with an additional symbol if desired. For now the current code uses printk(KERN_DEBUG and a straight conversion to pr_debug would eliminate the KERN_DEBUG the output. pr_debug without #define DEBUG or dynamic_debug is compiled away to nothing. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
