On Sat, Mar 10, 2012 at 12:09:28AM -0500, Ted Ts'o wrote:
> On Tue, Mar 06, 2012 at 03:58:12PM -0800, Darrick J. Wong wrote:
> > Detect mismatches of the inode and checksum, and prompt the user to fix the
> > situation.
> >
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> The new problem definitions were inserted into the wrong place in
> problem.c. This is something that was picked up by a unit test in the
> e2fsck directory:
>
> LD_LIBRARY_PATH=../lib DYLD_LIBRARY_PATH=../lib ./tst_problem
> *** Unordered problem table:
> curr code = 0x00010065: The bad @b @i looks @n.
> *** prev code = 0x00010067: @i %i passes checks, but checksum does not match @i.
> *** This is a programming error in e2fsck
> make[1]: *** [check] Error 1
>
> The fix was simple; just move the new lines in problem.c down two lines.
>
> > /* Quota inode is user visible */
> > { PR_1_QUOTA_INODE_NOT_HIDDEN,
> > N_("@q @i is visible to the user. "),
> > - PROMPT_CLEAR, PR_PREEN_OK },
> > + PROMPT_FIX, PR_PREEN_OK },
>
> PR1_QUOTA_INODE_NOT_HIDDEN isn't currently used, so there's no point
> changing it now. Depending on how this bit of the first class quota
> patch gets implemented, the message might change completely.
Ugh, that looks like a merge error on my end. Sorry and thanks for fixing it.
--D
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
