On Sun, 11 Mar 2012, Ted Ts'o wrote: > On Mon, Mar 05, 2012 at 08:49:33AM +0100, Lukas Czerner wrote: > > @@ -435,6 +481,7 @@ static void check_inode_bitmaps(e2fsck_t ctx) > > int skip_group = 0; > > int redo_flag = 0; > > io_manager manager = ctx->fs->io->manager; > > + unsigned long long first_free = fs->super->s_inodes_per_group + 1; > > This doesn't need to be an unsigned long long; an "int" will do just > as well. > > > + /* > > + * If the last inode is free, we can discard it as well. > > + */ > > + if (inodes >= first_free) > > + e2fsck_discard_inodes(ctx, group, first_free, > > + inodes - first_free + 1); > > There's no guarantee the last inode is free here. This needs to read: > > if (!bitmap && inodes >= first_free) Hi Ted, if the last inode is not free then: first_free = fs->super->s_inodes_per_group + 1; so the condition if (inodes >= first_free) would be false. Otherwise it is guaranteed that the last inode is free. But I agree that your change makes it more obvious. Thanks! -Lukas > > I'll fix this up in my version of the patches. > > - Ted > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
