On Fri, Feb 24, 2012 at 04:49:21PM -0500, Jeff Moyer wrote: > Hi, > > For extent-based files, you can perform DIO to holes, as mentioned in > the comments in ext4_ext_direct_IO. However, that function passes > DIO_SKIP_HOLES to __blockdev_direct_IO, which is *really* confusing to > the uninitiated reader. The key, here, is that the get_block function > passed in, ext4_get_block_write, completely ignores the create flag that > is passed to it (the create flag is passed in from the direct I/O code, > which uses the DIO_SKIP_HOLES flag to determine whether or not it should > be cleared). > > This is a long-winded way of saying that the DIO_SKIP_HOLES flag is > ultimately ignored. So, in the interest of preserving sanity, I propose > the following patch. > > Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
