Re: [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Feb 2012, Phillip Susi wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 2/24/2012 9:57 AM, Lukas Czerner wrote:
> >> I do not see how the group would become UNINIT again, so there is
> >> not reason to discard it. Previously we could count free block
> >> through out several groups (accounting or BLOCK_UNINIT groups as
> >> well. We do not do that now, because we discard every group
> >> separately.
> 
> Simple; delete some files.  Once all blocks in the block group are
> free again, it can go back to UNINIT.  Also the fs may have been
> formatted without discard, or moved with dd, or any number of ways
> that the bock allocation bitmap could still use a discard despite
> being uninitialized.

It does not work that way, uinit is never set back. If it has been
formated without discard it is user choice, moving the image to the
thinly provisioned device, or ssd with dd is really bad idea anyway.
That said, UNINIT means that it has not been used and hence there
should be nothing to reclaim.

-Lukas

> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iQEcBAEBAgAGBQJPR7MrAAoJEJrBOlT6nu751oMIAN4YsKxC5XjHOTyif0U4Pffj
> x0TCcXW+0BS6bOfwvGq/3DLO9oCJXOh6mCIPxNNJZJ0NQt0t6yLmpnuZIw7AXzJT
> +WCxduNxnu9e/bIy1vzKlwcUkzd+lb8XIljEcO9RBDj+3LUFT4YYlCE8yiITze8V
> EZiE81U1IJtguhWzqFQmOsJrH0KP5kb7BE36yn5I+yfs5YYc3CyMrqi4SVpdv4gX
> /+YoroJCEa89nsk6pluk+uAGPd/gxeSC6w32YjJqaM5bVLpiD6yhKsqIXNQK8HzB
> uXNxZvvrHLBBQtp31+r0yy90K3eQmc2ycwn54DKkK+vOioH7Q2AB+s8YTxr/Hq0=
> =DOVr
> -----END PGP SIGNATURE-----
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux