On 2012-02-13, at 2:02 PM, Ted Ts'o wrote: > On Wed, Oct 26, 2011 at 06:49:16PM +0800, Bobi Jam wrote: >> The per-commit callback is now used by mballoc code to manage free >> space bitmaps after deleted blocks have been released. This patch >> expand it to contain multiple different callbacks. >> >> Signed-off-by: Bobi Jam <bobijam@xxxxxxxxxxxxx> >> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxxxxxx> > > Thanks, applied. > > Note: since this callback is called *after* the commit is completed, > we can't really use this to do things like compute metadata checksums > or update atimes more efficiently, since those sorts of things have to > happen *before* we actually finish up the commit. Right, though a similar commit callback (using the same infrastructure) could be added before the commit is started. There is already the buffer_head callback that OCFS is using for their data checksums, which is called before the transaction commit. I haven't looked at that closely enough to know whether the ext4 metadata checksums could use it (e.g. if it can handle different metadata block types with different checksum chunks and locations). Cheers, Andreas -- Andreas Dilger Whamcloud, Inc. Principal Lustre Engineer http://www.whamcloud.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
