On Mon, Jan 16, 2012 at 8:01 AM, Jan Kara <jack@xxxxxxx> wrote: > > Hum, let me understand this. I understand the meaning of buffer_uptodate > bit as "the buffer has at least as new content as what is on disk". Now > when storage cannot write the block under the buffer, the contents of the > buffer is still "at least as new as what is (was) on disk". No. Stop making crap up. If the write fails, the buffer contents have *nothing* to do with what is on disk. You don't know what the disk contents are. So clearly the buffer cannot be up-to-date. Now, feel free to use *other* arguments for why we shouldn't clear the up-to-date bit, but using the disk contents as one is pure and utter garbage. And it is *obviously* pure and utter garbage. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html