On 8/13/11 9:28 PM, Theodore Ts'o wrote:
> This doesn't make much sense, and it exposes a bug in the kernel where
> attempts to create a new file in an append-only directory using
> O_CREAT will fail (but still leave a zero-length file). This was
> discovered when xfstests #79 was generalized so it could run on all
> file systems.
Curious about the status of this one; I think it makes sense to me, but
I don't think it ever made it upstream? I'd be willing to give it a:
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Are there concerns about it or did it just slip through the cracks?
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> ---
> fs/ext4/ext4.h | 3 +--
> include/linux/ext2_fs.h | 4 ++--
> include/linux/ext3_fs.h | 4 ++--
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index e717dfd..be593d5 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -357,8 +357,7 @@ struct flex_groups {
>
> /* Flags that should be inherited by new inodes from their parent. */
> #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\
> - EXT4_SYNC_FL | EXT4_IMMUTABLE_FL | EXT4_APPEND_FL |\
> - EXT4_NODUMP_FL | EXT4_NOATIME_FL |\
> + EXT4_SYNC_FL | EXT4_NODUMP_FL | EXT4_NOATIME_FL |\
> EXT4_NOCOMPR_FL | EXT4_JOURNAL_DATA_FL |\
> EXT4_NOTAIL_FL | EXT4_DIRSYNC_FL)
>
> diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
> index 53792bf..ce1b719 100644
> --- a/include/linux/ext2_fs.h
> +++ b/include/linux/ext2_fs.h
> @@ -197,8 +197,8 @@ struct ext2_group_desc
>
> /* Flags that should be inherited by new inodes from their parent. */
> #define EXT2_FL_INHERITED (EXT2_SECRM_FL | EXT2_UNRM_FL | EXT2_COMPR_FL |\
> - EXT2_SYNC_FL | EXT2_IMMUTABLE_FL | EXT2_APPEND_FL |\
> - EXT2_NODUMP_FL | EXT2_NOATIME_FL | EXT2_COMPRBLK_FL|\
> + EXT2_SYNC_FL | EXT2_NODUMP_FL |\
> + EXT2_NOATIME_FL | EXT2_COMPRBLK_FL |\
> EXT2_NOCOMP_FL | EXT2_JOURNAL_DATA_FL |\
> EXT2_NOTAIL_FL | EXT2_DIRSYNC_FL)
>
> diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h
> index 67a803a..0244611 100644
> --- a/include/linux/ext3_fs.h
> +++ b/include/linux/ext3_fs.h
> @@ -180,8 +180,8 @@ struct ext3_group_desc
>
> /* Flags that should be inherited by new inodes from their parent. */
> #define EXT3_FL_INHERITED (EXT3_SECRM_FL | EXT3_UNRM_FL | EXT3_COMPR_FL |\
> - EXT3_SYNC_FL | EXT3_IMMUTABLE_FL | EXT3_APPEND_FL |\
> - EXT3_NODUMP_FL | EXT3_NOATIME_FL | EXT3_COMPRBLK_FL|\
> + EXT3_SYNC_FL | EXT3_NODUMP_FL |\
> + EXT3_NOATIME_FL | EXT3_COMPRBLK_FL |\
> EXT3_NOCOMPR_FL | EXT3_JOURNAL_DATA_FL |\
> EXT3_NOTAIL_FL | EXT3_DIRSYNC_FL)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
