On 12/19/2011 04:32 PM, Andreas Dilger wrote: > On 2011-12-18, at 15:24, Tao Ma <tm@xxxxxx> wrote: > >> From: Tao Ma <boyu.mt@xxxxxxxxxx> >> >> Currently, in ext4_iget we do a simple check to see whether >> there does exist some information starting from the end >> of i_extra_size. With inline data added, this procedure >> is more complicated. So move it to a new function named >> ext4_iget_extra_inode. >> >> + } else >> + ext4_iget_extra_inode(inode, raw_inode, ei); >> } else > > (style) if one half of an if-else uses braces then the other half should as well. sure, I will change it in the next version. Thanks for the review. Thanks Tao -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html