On Mon, Nov 28, 2011 at 03:26:43PM -0800, Darrick J. Wong wrote:
> + /* Load the checksum driver */
> + if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
> + EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) {
> + sbi->s_chksum_driver = crypto_alloc_shash("crc32c", 0, 0);
> + if (IS_ERR(sbi->s_chksum_driver)) {
> + ret = PTR_ERR(sbi->s_chksum_driver);
> + sbi->s_chksum_driver = NULL;
> + goto failed_mount;
> + }
> + }
Unless the crypto engine printk's a message if the crc32c algorithm is
not available (perhaps even if it does), it's probably going to be a
good idea to issue an ext4_msg() saying that we're failing because we
couldn't load the crc32c crypto module. Otherwise the user will get a
mysterious failure (including a message from mount to check 'dmesg |
tail'), and then when they look at the kernel messages, they won't see
what might have gone wrong, and then they'll send a complaint to
ext3-users or linux-ext4....
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
