From: Dave Chinner <dchinner@xxxxxxxxxx> USE_BIG_LOOPFS is really misnamed - it can be used on real devices just as easily as loop devices. It really means we are testing a large scratch device and that we should enable the special filesystem filling and checking options that enable xfstests to be run sanely on large XFS filesystems. Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> --- 004 | 2 +- 015 | 2 +- 030 | 2 +- 031 | 2 +- 032 | 2 +- 033 | 4 ++-- 041 | 2 +- 049 | 2 +- 083 | 2 +- 092 | 2 +- 148 | 2 +- 149 | 2 +- common | 2 +- common.rc | 12 ++++++------ setup | 5 +++-- 15 files changed, 23 insertions(+), 22 deletions(-) diff --git a/004 b/004 index 9f28e17..23729da 100755 --- a/004 +++ b/004 @@ -64,7 +64,7 @@ _supported_os IRIX Linux _need_to_be_root _require_scratch -_require_nobigloopfs +_require_no_large_scratch_dev rm -f $seq.full diff --git a/015 b/015 index 4206b93..a99f1ed 100755 --- a/015 +++ b/015 @@ -52,7 +52,7 @@ _supported_fs generic _supported_os IRIX Linux _require_scratch -_require_nobigloopfs +_require_no_large_scratch_dev _scratch_mkfs_sized `expr 50 \* 1024 \* 1024` >/dev/null 2>&1 \ || _fail "mkfs failed" diff --git a/030 b/030 index 74147d4..cd040a9 100755 --- a/030 +++ b/030 @@ -63,8 +63,8 @@ _check_ag() _supported_fs xfs _supported_os IRIX Linux -_require_nobigloopfs _require_scratch +_require_no_large_scratch_dev DSIZE="-dsize=100m,agcount=6" diff --git a/031 b/031 index b062277..fb6f15b 100755 --- a/031 +++ b/031 @@ -97,8 +97,8 @@ EOF _supported_fs xfs _supported_os IRIX Linux -_require_nobigloopfs _require_scratch +_require_no_large_scratch_dev # sanity test - default + one root directory entry # Note: must do this proto/mkfs now for later inode size calcs diff --git a/032 b/032 index 4261ca2..d093b45 100755 --- a/032 +++ b/032 @@ -41,8 +41,8 @@ rm -f $seq.full _supported_fs xfs _supported_os Linux -_require_nobigloopfs _require_scratch +_require_no_large_scratch_dev echo "Silence is golden." for fs in `echo /sbin/mkfs.* | sed -e 's/.sbin.mkfs.//g'` diff --git a/033 b/033 index 9651f26..68a688e 100755 --- a/033 +++ b/033 @@ -76,9 +76,9 @@ _filter_bad_ids() # real QA test starts here _supported_fs xfs _supported_os IRIX Linux - -_require_nobigloopfs + _require_scratch +_require_no_large_scratch_dev # devzero blows away 512byte blocks, so make 512byte inodes (at least) _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs diff --git a/041 b/041 index 2800811..28dcb33 100755 --- a/041 +++ b/041 @@ -50,7 +50,7 @@ _supported_fs xfs _supported_os IRIX Linux _require_scratch -_require_nobigloopfs +_require_no_large_scratch_dev umount $SCRATCH_DEV 2>/dev/null _fill() diff --git a/049 b/049 index c6c4faa..e37b2d3 100755 --- a/049 +++ b/049 @@ -60,9 +60,9 @@ _log() echo "--- $*" >> $seq.full } -_require_nobigloopfs _require_nonexternal _require_scratch +_require_no_large_scratch_dev _require_loop _require_ext2 diff --git a/083 b/083 index e0670b9..7a73f30 100755 --- a/083 +++ b/083 @@ -58,7 +58,7 @@ _supported_fs generic _supported_os IRIX Linux _require_scratch -_require_nobigloopfs +_require_no_large_scratch_dev rm -f $seq.full diff --git a/092 b/092 index 429fa80..02ccc71 100755 --- a/092 +++ b/092 @@ -48,7 +48,7 @@ _cleanup() _supported_fs xfs _supported_os IRIX Linux _require_scratch -_require_nobigloopfs +_require_no_large_scratch_dev MOUNT_OPTIONS="$MOUNT_OPTIONS -o inode64" _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null diff --git a/148 b/148 index 76cbf37..7bb1722 100755 --- a/148 +++ b/148 @@ -66,8 +66,8 @@ _check_ag() _supported_fs xfs _supported_os IRIX Linux -_require_nobigloopfs _require_scratch +_require_no_large_scratch_dev DSIZE="-dsize=100m" diff --git a/149 b/149 index 5131a45..193e6d7 100755 --- a/149 +++ b/149 @@ -100,8 +100,8 @@ EOF _supported_fs xfs _supported_os IRIX Linux -_require_nobigloopfs _require_scratch +_require_no_large_scratch_dev # sanity test - default + one root directory entry # Note: must do this proto/mkfs now for later inode size calcs diff --git a/common b/common index 7d13078..da86cd9 100644 --- a/common +++ b/common @@ -239,7 +239,7 @@ s/ .*//p ;; --large-fs) - export USE_BIG_LOOPFS=yes + export LARGE_SCRATCH_DEV=yes xpand=false ;; diff --git a/common.rc b/common.rc index cab0b64..fdeef1c 100644 --- a/common.rc +++ b/common.rc @@ -310,7 +310,7 @@ _scratch_mkfs_xfs() cat $tmp_dir.mkfsstd rm -f $tmp_dir.mkfserr $tmp_dir.mkfsstd - if [ "$USE_BIG_LOOPFS" = yes ]; then + if [ "$LARGE_SCRATCH_DEV" = yes ]; then [ -z "$RETAIN_AG_BYTES" ] && RETAIN_AG_BYTES=0 ./tools/ag-wipe -q -r $RETAIN_AG_BYTES $SCRATCH_DEV fi @@ -432,7 +432,7 @@ _scratch_xfs_repair() SCRATCH_OPTIONS="-l$SCRATCH_LOGDEV" [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ] && \ SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -r$SCRATCH_RTDEV" - [ "$USE_BIG_LOOPFS" = yes ] && SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -t" + [ "$LARGE_SCRATCH_DEV" = yes ] && SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -t" $XFS_REPAIR_PROG $SCRATCH_OPTIONS $* $SCRATCH_DEV } @@ -821,9 +821,9 @@ _require_ext2() # this test requires that (large) loopback device files are not in use # -_require_nobigloopfs() +_require_no_large_scratch_dev() { - [ "$USE_BIG_LOOPFS" = yes ] && \ + [ "$LARGE_SCRATCH_DEV" = yes ] && \ _notrun "Large filesystem testing in progress, skipped this test" } @@ -1164,7 +1164,7 @@ _check_xfs_filesystem() [ "$FSTYP" != xfs ] && return 0 testoption="" - [ "$USE_BIG_LOOPFS" = yes ] && testoption=-t + [ "$LARGE_SCRATCH_DEV" = yes ] && testoption=-t type=`_fs_type $device` ok=1 @@ -1203,7 +1203,7 @@ _check_xfs_filesystem() ok=0 fi # repair doesn't scale massively at this stage, optionally skip it for now - [ "$USE_BIG_LOOPFS" = yes ] || \ + [ "$LARGE_SCRATCH_DEV" = yes ] || \ $XFS_REPAIR_PROG -n $extra_log_options $extra_rt_options $device >$tmp.repair 2>&1 if [ $? -ne 0 ] then diff --git a/setup b/setup index 62798cc..5225951 100755 --- a/setup +++ b/setup @@ -23,7 +23,7 @@ fi [ "$USE_EXTERNAL" = yes ] || USE_EXTERNAL=no [ "$USE_LBD_PATCH" = yes ] || USE_LBD_PATCH=no -[ "$USE_BIG_LOOPFS" = yes ] || USE_BIG_LOOPFS=no +[ "$LARGE_SCRATCH_DEV" = yes ] || LARGE_SCRATCH_DEV=no [ "$USE_ATTR_SECURE" = yes ] || USE_ATTR_SECURE=no [ -z "$FSTYP" ] && FSTYP="xfs" @@ -31,5 +31,6 @@ cat <<EOF TEST: DIR=$TEST_DIR DEV=$TEST_DEV rt=[$TEST_RTDEV] log=[$TEST_LOGDEV] TAPE: dev=[$TAPE_DEV] rmt=[$RMT_TAPE_DEV] rmtirix=[$RMT_TAPE_USER@$RMT_IRIXTAPE_DEV] SCRATCH: MNT=$SCRATCH_MNT DEV=$SCRATCH_DEV rt=[$SCRATCH_RTDEV] log=[$SCRATCH_LOGDEV] -VARIABLES: external=$USE_EXTERNAL largeblk=$USE_LBD_PATCH fstyp=$FSTYP bigloopfs=$USE_BIG_LOOPFS attrsecure=$USE_ATTR_SECURE +VARIABLES: external=$USE_EXTERNAL largeblk=$USE_LBD_PATCH fstyp=$FSTYP + large_scratch_dev=$LARGE_SCRATCH_DEV attrsecure=$USE_ATTR_SECURE EOF -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html