2011/11/20 Namjae Jeon <linkinjeon@xxxxxxxxx>: > I try to set to SLAB_MEM_SPREAD flags in groups info caches accoding to http://lwn.net/Articles/173654/. > And other filesystems have already set to this flags when using slab caches in fs. > I believe that it is useful by original Paul jackson's patch and other fs is currently using this flags. > Ted's opinion is that theoretically it would be sound to have that flag set with groups info slab cache. > > Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx> > Signed-off-by: Amit Sahrawat <amit.sahrawat83@xxxxxxxxx> > --- > fs/ext4/mballoc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index e2d8be8..7aacbbe 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2407,7 +2407,8 @@ static int ext4_groupinfo_create_slab(size_t size) > bb_counters[blocksize_bits + 2]); > > cachep = kmem_cache_create(ext4_groupinfo_slab_names[cache_index], > - slab_size, 0, SLAB_RECLAIM_ACCOUNT, > + slab_size, 0, SLAB_RECLAIM_ACCOUNT | > + SLAB_MEM_SPREAD, > NULL); > > ext4_groupinfo_caches[cache_index] = cachep; > -- > 1.7.4.4 > > Hi. Ted. This patch is not really meaningful ? or you need to see performance data although cpuset mem spread flags patch is proved before. I am waiting for your decision. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
