Any feedback for this patch? We surely don't need 'ret2' variable in this code. Thanks & Regards, Amit Sahrawat On Fri, Nov 11, 2011 at 8:32 PM, Namjae Jeon <linkinjeon@xxxxxxxxx> wrote: > ret2 is not needed in ext4_flush_completed_IO(). > > Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxx> > Signed-off-by: Amit Sahrawat <amit.sahrawat83@xxxxxxxxx> > --- > fs/ext4/fsync.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c > index 00a2cb7..40397ac 100644 > --- a/fs/ext4/fsync.c > +++ b/fs/ext4/fsync.c > @@ -81,7 +81,6 @@ int ext4_flush_completed_IO(struct inode *inode) > struct ext4_inode_info *ei = EXT4_I(inode); > unsigned long flags; > int ret = 0; > - int ret2 = 0; > > dump_completed_IO(inode); > spin_lock_irqsave(&ei->i_completed_io_lock, flags); > @@ -105,12 +104,10 @@ int ext4_flush_completed_IO(struct inode *inode) > */ > spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); > ret = ext4_end_io_nolock(io); > - if (ret < 0) > - ret2 = ret; > spin_lock_irqsave(&ei->i_completed_io_lock, flags); > } > spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); > - return (ret2 < 0) ? ret2 : 0; > + return (ret < 0) ? ret : 0; > } > > /* > -- > 1.7.4.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
