On Thu, Nov 10, 2011 at 12:23 AM, Andreas Dilger <adilger@xxxxxxxxx> wrote:
> On 2011-11-09, at 3:53 AM, Yongqiang Yang <xiaoqiangnk@xxxxxxxxx> wrote:
>
>> Now mke2fs initializes block bitmaps of groups having super block, on
>> the other hand ext4_init_block_bitmap in kernel can handle this case
>> rightly. So let mke2fs let block bitmaps of groups having super block
>> be uninitialized.
>
> Is that true of older kernels, or only newer ones? What about filesystems with META_BG set?
According to code of kernel 2.6.24 in which uninit_bg was introduced
in, kernel can handle the case and META_BG can also be handled
rightly. But it was not tested. I will do a test later.
Yongqiang.
>
> Cheers, Andreas
>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>
>> ---
>> lib/ext2fs/alloc_sb.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/ext2fs/alloc_sb.c b/lib/ext2fs/alloc_sb.c
>> index 0d1c000..7517fbc 100644
>> --- a/lib/ext2fs/alloc_sb.c
>> +++ b/lib/ext2fs/alloc_sb.c
>> @@ -65,8 +65,6 @@ int ext2fs_reserve_super_and_bgd(ext2_filsys fs,
>> ext2fs_mark_block_bitmap2(bmap, 0);
>>
>> if (old_desc_blk) {
>> - if (fs->super->s_reserved_gdt_blocks && fs->block_map == bmap)
>> - ext2fs_bg_flags_clear(fs, group, EXT2_BG_BLOCK_UNINIT);
>> for (j=0; j < old_desc_blocks; j++)
>> if (old_desc_blk + j < ext2fs_blocks_count(fs->super))
>> ext2fs_mark_block_bitmap2(bmap,
>> --
>> 1.7.5.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
