On Tue 01-11-11 10:06:19, Eryu Guan wrote:
> Call ext3_mark_recovery_complete() in ext3_fill_super() only if
> needs_recovery is non-zero.
>
> Besides that, print out "recovery complete" message after calling
> ext3_mark_recovery_complete().
OK, I don't see a problem in this patch. But is there some benefit in it?
I'm slightly nervous it could change something subtle...
Honza
>
> Cc: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
> ---
> fs/ext3/super.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 7beb69a..2681e0d 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2060,9 +2060,10 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
> EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS;
> ext3_orphan_cleanup(sb, es);
> EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS;
> - if (needs_recovery)
> + if (needs_recovery) {
> + ext3_mark_recovery_complete(sb, es);
> ext3_msg(sb, KERN_INFO, "recovery complete");
> - ext3_mark_recovery_complete(sb, es);
> + }
> ext3_msg(sb, KERN_INFO, "mounted filesystem with %s data mode",
> test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_JOURNAL_DATA ? "journal":
> test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_ORDERED_DATA ? "ordered":
> --
> 1.7.7.1
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
