On Oct 31, 2011, at 10:51 PM, Tao Ma wrote: >> if (!mutex_trylock(&inode->i_mutex)) { > So here, we spin_lock first and then mutex_lock. > But in ext4_flush_completed_IO, we mutex_lock first and > then spin_lock. Will lockdep complain about it? > Other than that, the patch looks good to me. It won't complain because it's a mutex_trylock(); so by definition it can't cause a deadlock. -- Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html