Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

Sorry, Cc did not work in git.

Yongqiang.
---------- Forwarded message ----------
From: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>
Date: Tue, Nov 1, 2011 at 9:21 AM
Subject: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize
var(eh) before using it
To: linux-ext4@xxxxxxxxxxxxxxx
Cc: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>


ext4_ext_convert_to_initialized() does not initialize eh before using it
and this is introduced in commit 864d21652.

Cc:Eric Gouriou <egouriou@xxxxxxxxxx>
Cc:"Theodore Ts'o" <tytso@xxxxxxx>
Signed-off-by: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>
---

Hi Eric,

Was that patch tested?

 fs/ext4/extents.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9dfdf8f..2798945 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2944,6 +2944,7 @@ static int
ext4_ext_convert_to_initialized(handle_t *handle,
               eof_block = map->m_lblk + map->m_len;

       depth = ext_depth(inode);
+       eh = path[depth].p_hdr;
       ex = path[depth].p_ext;
       ee_block = le32_to_cpu(ex->ee_block);
       ee_len = ext4_ext_get_actual_len(ex);
--
1.7.5.1




-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux