On Thu, Sep 15, 2011 at 03:09:37PM +0800, Robin Dong wrote: > From: Robin Dong <sanbai@xxxxxxxxxx> > > The kernel will crash on > > ext4_mb_mark_diskspace_used: > BUG_ON(ac->ac_b_ex.fe_len <= 0); > > after we set /sys/fs/ext4/sda/mb_group_prealloc to zero and create new files in an ext4 filesystem. > > The reason is: ac_b_ex.fe_len also set to zero(mb_group_prealloc) in ext4_mb_normalize_group_request > because the ac_flags contains EXT4_MB_HINT_GROUP_ALLOC. > > I think when someone set mb_group_prealloc to zero, it means DO NOT USE GROUP PREALLOCATION, > so we should set alloc-strategy to STREAM in this case. > > Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html