On Fri, Oct 21, 2011 at 01:08:55AM +0400, Dmitry Monakhov wrote:
> - add ext4_ext_try_shrink helper
> - ext4_mark_inode_dirty() called externally in order to allow
> caller to butch several inode updates in to one mark_dirty call.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
This patch is broken in two ways:
1) It drops the absolutely necessary calls to ext4_ext_get_access()
and ext4_ext_dirty(). If you don't do this you will get file
system corruptions.
2) Some of the callers to the new ext4_ext_try_shrink() helper depends
on it return 0 or 1 depending on whether the tree was shrunk, but
others assumed that it would return an error code. Which is OK,
since the error codes should be negative, but that means it's
critical that the callers check to see whether return code is
really an error before returning it.
Since this is just a cleanup, I'm going to skip this for now. Dmitry,
could you fix this up and resubmit? Thanks!!
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
