On 10/3/11 11:27 PM, Theodore Ts'o wrote:
> If the number of block groups exceeds 2**32, a bad cast would lead to
> a bogus "Not enough space to build proposed filesystem while setting
> up superblock" failure.
It's the proper cast now, but I don't think it fixes the problem, since they
are both __u32...
But in any case, for the actual change at least:
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
> ---
> lib/ext2fs/initialize.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c
> index 2875f97..b050a0a 100644
> --- a/lib/ext2fs/initialize.c
> +++ b/lib/ext2fs/initialize.c
> @@ -248,7 +248,7 @@ errcode_t ext2fs_initialize(const char *name, int flags,
> }
>
> retry:
> - fs->group_desc_count = (blk_t) ext2fs_div64_ceil(
> + fs->group_desc_count = (dgrp_t) ext2fs_div64_ceil(
> ext2fs_blocks_count(super) - super->s_first_data_block,
> EXT2_BLOCKS_PER_GROUP(super));
> if (fs->group_desc_count == 0) {
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
