On Fri, Sep 30, 2011 at 12:41:26PM -0700, Darrick J. Wong wrote: > The MMP code in libext2fs tries to gate MMP block swab'ing with this test: > > #ifdef EXT2FS_ENABLE_SWAPFS > if (fs->super->s_magic == ext2fs_swab16(EXT2_SUPER_MAGIC)) > > However, EXT2FS_ENABLE_SWAPFS never seems to be defined anywhere (all possible > #define's were cleaned out of e2fsprogs ages ago), and even if any still > existed, the field fs->super->s_magic is always in host byteorder, so the test > always fails. So, we can change the #ifdef to WORDS_BIGENDIAN (which is > conditionally defined on BE platforms) and get rid of the broken if test. > > (This fix came up while testing the metadata checksumming patchset) > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
