On Wed, Aug 10, 2011 at 10:48:43AM +0200, Yury V. Zaytsev wrote: > Block size can be specified manually via the -b option or deduced > automatically. Unfortunately, the check that it is still smaller than > the system page size is only performed right after the command line > options are parsed. > > Therefore, if buggy or inappropriately installed/configured hardware > hints that larger block sizes have to be used, mkfs will silently create > a file system which can not be mounted on the system in question. > > By moving the check beyond the last assignment to blocksize it is now > ensured, that mkfs will issue a warning even if inappropriate blocksize > was auto-detected. > > The new behavior can be easily tested, by exporting the following > variables before running mkfs: > > export MKE2FS_DEVICE_SECTSIZE=8192 > export MKE2FS_DEVICE_PHYS_SECTSIZE=8192 > > Signed-off-by: Yury V. Zaytsev <yury@xxxxxxxxxx> > Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> Thanks, I've merged this into the next branch. Apologies for the delay. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
