On Thu, Sep 15, 2011 at 01:10:41PM -0600, Andreas Dilger wrote: > > This is also a possible alternative, though it makes for more fragments that > need to be checksummed. I think as a general rule it makes sense to store > the checksum as the last word in the structure, if possible, so that the > checksum can be computed in a single call. This is already done for 128-byte > inodes and for 32-byte group descriptors, but should also be done for the > s_checksum field in the superblock (i.e. put it after s_reserved instead of > before). Or we just zero out the checksum field, checksum the entire data structure, and then fill in the newly calculated checksum. In fact that's what I assumed Darrick was going to do. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html