On Thu, Sep 15, 2011 at 05:03:37PM +0300, Amir Goldstein wrote:
> > I'd prefer if these comments were "Snapshot exclude bitmap block" so
> > that it is more clear what an exclude bitmap is used for.
>
> I'll change that.
I'll be sending out a combined patch very shortly which adds the
necessary fields for the snapshot and metadata checksum fields. I
just want to make sure we're all on the same page about reserved
fields as far as the on-disk format is concerned.
> >
> > For consistency, it would also be good to name these "_lo" to match the
> > kernel fields.
> >
>
> That's a major cleanup.
> Forgive me for not picking up that glove...
One way of handling these sorts of cleanups is to make the change in
the header file, and then do something like this:
#define bg_exclude_bitmap bg_exclude_bitmap_lo
Then once you add the accessor functions to set/get the
exclude_bitmap, you can delete the #define to make sure you fixed up
all of your code to actually use the accessor functions.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
