Re: [PATCH 32/37] libext2fs: Extend inode checksum to cover the EA block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 31, 2011 at 05:38:36PM -0700, Darrick J. Wong wrote:
> Now that e2fsprogs knows to read the entire s_inode_size, change the inode
> checksum code to checksum the entire block.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>

This should get folded into whatever patch actually starts
checksumming the inode.  There's no point keeping it separate.  Also
note that changes like this are problematic as we bisect the tree,
since the meaning of the fields change as we progess through time.
Although from a development perspective this may be the order in which
you did things, from a patch review perspective it's better if you
collapse functional changes together, especially when it relates to
"this is how we calculate this field in the
inode/superblock/whatever".

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux