Re: [PATCH] mke2fs: Use ext2fs_flush() only once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, applied, with an obvious bugfix:

> -void print_check_message(ext2_filsys fs)
> +void print_check_message(unsigned int mnt, unsigned int check)
>  {
>  	printf(_("This filesystem will be automatically "
>  		 "checked every %d mounts or\n"
>  		 "%g days, whichever comes first.  "
>  		 "Use tune2fs -c or -i to override.\n"),
> -	       fs->super->s_max_mnt_count,
> -	       (double)fs->super->s_checkinterval / (3600 * 24));
> +		mnt, check / (3600 * 24));
>  }

../../misc/util.c: In function ‘print_check_message’:
../../misc/util.c:291: warning: format ‘%g’ expects type ‘double’, but argument 3 has type ‘unsigned int’

the (double) cast was dropped in your patch.

The message should be made a bit better in the case that
s_max_mnt_count or s_checkinterval is zero, but that's a separate
patch.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux