On 09/06/2011 09:38 AM, Allison Henderson wrote:
On 09/05/2011 09:59 PM, Ted Ts'o wrote:
Allison,
Many, many thanks for your work on this patch series!! It's clearly
been a very long slog.
I've pulled in the first three patches, since I think those are
clearly correct at this point. One minor change I've made was I fixed
the spelling the flag, which I channged to
EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED. (Sorry, but seeing MAPED
everywhere was just grating on my nerves. :-)
I didn't want to apply your 4th patch in the series since we're
planning on reducing the usage of i_mutex in the fs/ext4 code proper,
as recommended by Christoph. It wasn't immediately obvious to me
whether it was safe to apply any of the patches after #4, so for now
I've just merged in the first three, since they clearly fix real
problems that show up in xfstests.
Can you comment on whether patches #5, #6, and #7 depend on #4?
Thanks,
- Ted
Hi Ted,
Patches 5 and 6 do not depend on 4, and this set only has 6 patches, so
no need to worry about patch 7 :) So it is ok to just skip patch 4, I
will see if I can find another way to solve the race conditions
Yongqiang pointed out with out the use of i_mutex. Many thanks to you
too for all the help along the way. :)
Allison Henderson
Hi Ted,
I've been working on another way to resolve the punch hole races with
out i_mutex, and Im starting to think that maybe we're going to need
another semaphore some where. Can I ask what the plans are for reducing
the usage of i_mutex in ext4? I wasnt sure if someone might already be
doing this. Thx!
Allison Henderson
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
