On Thu, Aug 04, 2011 at 11:48:02AM +0800, Robin Dong wrote: > From: Robin Dong <sanbai@xxxxxxxxxx> > > The argument "save_blocks_count" and the block bitmap has the unit of cluster, > so it don't need EXT2FS_C2B to convert argument "i". > > This patch is based on "next" branch of e2fsprogs. > > Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx> > Cc: Ted Ts'o <tytso@xxxxxxx> No, I don't think this is right. Regardless of whether the unit of the block bitmap is cluster- or block- (only while mke2fs is running, and only initially) based, the argument to ext2fs_{test,mark,unmark}_block_bitmap is always in blocks. That's why the EXT2FS_C2B is necessary. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html