On Wed, 3 Aug 2011, Li Zefan wrote: > 09:58, Wang Sheng-Hui wrote: > > The patch is against 3.0 > > > > The arg of kjournald/kjournald2 is void *, and points to type > > journal_t. We should convert it to journal_t * explicitly in > > the kjournald/kjournald2 function body. > > > > Why? > > Implicit convertion from void * to foo * is ok. Did the compiler > complain about this to you? > Not only is it perfectly OK to rely on the implicit conversion, a lot of work has gone into actively removing such unneeded explicit casts over the years, so let's not introduce new ones. -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
