On Mon 01-08-11 18:45:58, Toshiyuki Okajima wrote:
> (2011/08/01 17:45), Jan Kara wrote:
> >On Mon 01-08-11 13:54:51, Toshiyuki Okajima wrote:
> >>If there are some inodes in orphan list while a filesystem is being
> >>read-only mounted, we should recommend that pepole umount and then
> >>mount it when they try to remount with read-write. But the current
> >>message/comment recommends that they umount and then remount it.
> >>
> >>ext3_remount:
> >> /*
> >> * If we have an unprocessed orphan list hanging
> >> * around from a previously readonly bdev mount,
> >> * require a full umount/remount for now.
> >> ^^^^^^^^^^^^^^
> >> */
> >> if (es->s_last_orphan) {
> >> printk(KERN_WARNING "EXT3-fs: %s: couldn't "
> >> "remount RDWR because of unprocessed "
> >> "orphan inode list. Please "
> >> "umount/remount instead.\n",
> >> ^^^^^^^^^^^^^^
> >> sb->s_id);
>
> > OK, so how about using "umount& mount"? The '/' is what would confuse me
> OK. I modify it like your comment.
>
> umount/mount => umount & mount
Thanks.
> >the most... BTW, I guess you didn't really see this message in practice, did
> >you?
> No.
> I have seen this message in practice while quotacheck command was repeatedly
> executed per an hour.
Interesting. Are you able to reproduce this? Quotacheck does remount
read-only + remount read-write but you cannot really remount the filesystem
read-only when it has orphan inodes and so you should not see those when
you remount read-write again. Possibly there's race between remounting and
unlinking...
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
