Re: [PATCH] ext4: Add missing cast in ext4_fallocate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 25, 2011 at 04:33:49PM +0900, Utako Kusaka wrote:
> Cast map.m_lblk to loff_t.
> 
> File size is corrupt when we get an ENOSPC.
> Logical block number is __u32, so new_size will be set to overflowed value.
> 
> # df -T /mnt/mp1
> Filesystem    Type   1K-blocks      Used Available Use% Mounted on
> /dev/sda6     ext4     9843276    153056   9190200   2% /mnt/mp1
> # fallocate -o 0 -l 2199023251456 /mnt/mp1/testfile
> fallocate: /mnt/mp1/testfile: fallocate failed: No space left on device
> # stat /mnt/mp1/testfile
>   File: `/mnt/mp1/testfile'
>   Size: 4293656576	Blocks: 19380440   IO Block: 4096   regular file
> Device: 806h/2054d	Inode: 12          Links: 1
> Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
> Access: 2011-07-25 13:01:31.414490496 +0900
> Modify: 2011-07-25 13:01:31.414490496 +0900
> Change: 2011-07-25 13:01:31.454490495 +0900
> 
> Signed-off-by: Utako Kusaka <u-kusaka@xxxxxxxxxxxxx>

Thanks, added to the ext4 tree.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux