On Wed, Jun 29, 2011 at 08:57:51AM +0800, Robin Dong wrote: > This patch avoids an extraneous lookup of the extent cache > in ext4_ext_map_blocks() when the flag > EXT4_GET_BLOCKS_PUNCH_OUT_EXT is absent. > > The existing logic was performing the lookup but not making > use of the result. The patch simply reverses the order of evaluation > in the condition. > > Since ext4_ext_in_cache() does not initialize newex on misses, bypassing > its invocation does not introduce any new issue in this regard. > > Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx> > Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx> > Reviewed-by: Eric Gouriou <egouriou@xxxxxxxxxx> Thanks added to the ext4 tree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html