On Fri, Jul 01, 2011 at 11:27:53PM +0800, Tao Ma wrote: > From: Tao Ma <boyu.mt@xxxxxxxxxx> > > When we trim some free blocks in a group of ext4, we should > calculate the free blocks properly and check whether there are > enough freed blocks left for us to trim. Current solution will > only calculate free spaces if they are large for a trim which > isn't appropriate. > > Let us see a small example: > a group has 1.5M free which are 300k, 300k, 300k, 300k, 300k. > And minblocks is 1M. With current solution, we have to iterate > the whole group since these 300k will never be subtracted from > 1.5M. But actually we should exit after we find the first 2 > free spaces since the left 3 chunks only sum up to 900K if we > subtract the first 600K although they can't be trimed. > > Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx> > Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx> Added to the ext4 tree, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
