On 06/21/2011 05:40 AM, Coly Li wrote:
On 2011年06月21日 04:28, Bernd Schubert Wrote:
changes from v1 -> v2:
Use %p as suggested by Coly Li
Compilation of ext4/namei.c brought up an error and warning messages
when compiled with -DDX_DEBUG
Signed-off-by: Bernd Schubert<bernd.schubert@xxxxxxxxxxxxxxxxxx>
---
fs/ext4/namei.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index b754b77..bfb749f 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -288,7 +288,7 @@ static struct stats dx_show_leaf(struct dx_hash_info *hinfo, struct ext4_dir_ent
char *name = de->name;
while (len--) printk("%c", *name++);
ext4fs_dirhash(de->name, de->name_len,&h);
- printk(":%x.%u ", h.hash,
+ printk(":%x.%p ", h.hash,
((char *) de - base));
}
space += EXT4_DIR_REC_LEN(de->name_len);
@@ -1013,7 +1013,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, const struct q
*err = -ENOENT;
errout:
- dxtrace(printk(KERN_DEBUG "%s not found\n", name));
+ dxtrace(printk(KERN_DEBUG "%s not found\n", d_name->name));
dx_release (frames);
return NULL;
}
It's OK for me.
Reviewed-by: Coly Li<bosong.ly@xxxxxxxxxx>
Arg, actually we have to change the printk to
printk(":%x.%p ", h.hash,
(void *) ((char *) de - base));
to avoid another warning. Seems I forgot to enable -DDX_DEBUG when I
tested it :(
Cheers,
Bernd
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
