Ted, I was going to send some more fixes, but it looks like your commit 94968e74 "libext2fs: teach bitmap functions about bigalloc/cluster" breaks the "f_lotsbad" test, which I found via git bisect and verified is the offending commit: --- ./f_lotsbad/expect.1 2011-06-01 20:25:00.871615457 +0000 +++ f_lotsbad.1.log 2011-06-17 05:33:37.398073505 +0000 @@ -26,6 +26,7 @@ Restarting e2fsck from the beginning... Pass 1: Checking inodes, blocks, and sizes +Illegal block number passed to ext2fs_test_block_bitmap #0 for in-use block map Pass 2: Checking directory structure Entry 'termcap' in / (2) has deleted/unused inode 12. Clear? yes I couldn't see the obvious correlation between the failure and the patch, though it is clear the patch is changing ext2fs_test_generic_bitmap(), but all of the changes should be no-ops because cluster_bits should be 0 unless bigalloc is enabled. My tree is up to b2e6c86d6, "mke2fs, e2fsck: fix i_blocks handling for bigalloc file systems", which AFAICS is the latest. Cheers, Andreas -- Andreas Dilger Principal Engineer Whamcloud, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
