On Wed, May 25, 2011 at 12:43:36PM +0200, Jan Kara wrote: > Mostly trivial conversion. We fix a bug that IS_IMMUTABLE and IS_APPEND > files could not be truncated during failed writes as we change the code. > In fact we remove the test altogether because do_sys_[f]truncate() and > may_open() do necessary checks anyway. This doesn't look quite correct me. One of the major points of the new truncate sequence is to to *_truncate_page before updating i_size, so that we can properly handle an error there. With your patch it's still called too late. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html