On Tue 24-05-11 00:17:58, Eryu Guan wrote:
> jbd2__journal_start() returns an ERR_PTR() value rather than NULL on
> failure.
>
> Cc: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
Thanks, but please include Ted Ts'o <tytso@xxxxxxx> in JBD2 patches.
Thanks.
Ted, I've realized that MAINTAINERS has only entry like:
JOURNALLING LAYER FOR BLOCK DEVICES (JBD)
M: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
M: Jan Kara <jack@xxxxxxx>
L: linux-ext4@xxxxxxxxxxxxxxx
S: Maintained
F: fs/jbd*/
F: include/linux/ext*jbd*.h
F: include/linux/jbd*.h
I guess you should add a separate entry for JBD2 so that people will find
you ;).
Honza
> ---
> fs/jbd2/transaction.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..7e6a5d6 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -316,7 +316,8 @@ static handle_t *new_handle(int nblocks)
> * This function is visible to journal users (like ext3fs), so is not
> * called with the journal already locked.
> *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
> */
> handle_t *jbd2__journal_start(journal_t *journal, int nblocks, int gfp_mask)
> {
> --
> 1.7.3.4
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
