On Mon 16-05-11 11:49:22, Lukas Czerner wrote: > On Mon, 16 May 2011, Amir Goldstein wrote: > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > > index fc827bb..2689351 100644 > > --- a/fs/ext4/super.c > > +++ b/fs/ext4/super.c > > @@ -4681,6 +4681,9 @@ static int ext4_quota_off(struct super_block > > *sb, int type) > > if (test_opt(sb, DELALLOC)) > > sync_filesystem(sb); > > > > + if (!inode) > > + goto out; > > Just out of curiosity, why would the quota inode be NULL ? Because quota is already turned off (we then release all references to quota file). Just what I don't understand is why in Amir's testing quota is not turned on before calling quota off. Because when I run the same test, I don't trigger the issue. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
