Hi, On Wed, May 11, 2011 at 10:10:43PM +0100, Mel Gorman wrote: > > > diff --git a/mm/slub.c b/mm/slub.c > > > index 98c358d..1071723 100644 > > > --- a/mm/slub.c > > > +++ b/mm/slub.c > > > @@ -1170,7 +1170,8 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > > > * Let the initial higher-order allocation fail under memory pressure > > > * so we fall-back to the minimum order allocation. > > > */ > > > - alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY | __GFP_NO_KSWAPD) & ~__GFP_NOFAIL; > > > + alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY | __GFP_NO_KSWAPD) & > > > + ~(__GFP_NOFAIL | __GFP_WAIT); > > > > __GFP_NORETRY is a no-op without __GFP_WAIT. > > > > True. I'll remove it in a V2 but I won't respin just yet. Nothing wrong and no performance difference with clearing __GFP_NORETRY too, if something it doesn't make sense for a caller to use __GFP_NOFAIL without __GFP_WAIT so the original version above looks cleaner. I like this change overall to only poll the buddy allocator without spinning kswapd and without invoking lumpy reclaim. Like you noted in the first mail, compaction was disabled, and very bad behavior is expected without it unless GFP_ATOMIC|__GFP_NO_KSWAPD is set (that was the way I had to use before disabling lumpy compaction when first developing THP too for the same reasons). But when compaction enabled slub could try to only clear __GFP_NOFAIL and leave __GFP_WAIT and no bad behavior should happen... but it's probably slower so I prefer to clear __GFP_WAIT too (for THP compaction is worth it because the allocation is generally long lived, but for slub allocations like tiny skb the allocation can be extremely short lived so it's unlikely to be worth it). So this way compaction is then invoked only by the minimal order allocation later if needed. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
